Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid adding (attribute=) part to filter which will confuse LDAP servers #39058

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Avoid adding (attribute=) part to filter which will confuse LDAP servers #39058

merged 1 commit into from
Aug 8, 2023

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Jun 29, 2023 •
edited
Loading

Summary

Fix empty filter search part introduced by #32499

Checklist

@come-nc
Avoid adding (attribute=) part to filter which will confuse LDAP servers
4a03518 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added the 3. to review Waiting for reviews label Jun 29, 2023
@come-nc come-nc added this to the Nextcloud 28 milestone Jun 29, 2023
@come-nc come-nc self-assigned this Jun 29, 2023
julien-nc
julien-nc approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@szaimen szaimen requested review from blizzz, a team, ArtificialOwl and icewind1991 and removed request for a team July 14, 2023 08:53
@come-nc
Copy link
Contributor Author

come-nc commented Aug 8, 2023

/backport to stable27

ChristophWurst
ChristophWurst approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an LDAP expert but the changes looks reasonable 👍

@come-nc come-nc merged commit b155f87 into master Aug 8, 2023
@come-nc come-nc deleted the fix/fix-ldap-filters-for-empty-search branch August 8, 2023 07:21
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Aug 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@julien-nc julien-nc julien-nc approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

Assignees

@come-nc come-nc

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

[Bug]: Database error when running migration 1027Date20230504122946 for app dav: LDAP Operations error
4 participants
@come-nc @AndyScherzinger @ChristophWurst @julien-nc