-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(TagSearchProvider): Short circuit if no tag matches the query #39062
Conversation
Psalm complains about the parameter of getAllTags but otherwise looks reasonable :) |
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
42cd266
to
29c0e07
Compare
/backport to stable27 |
/backport to stable26 |
/backport to stable25 |
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
The backport to stable25 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable25
git pull origin stable25
# Create the new backport branch
git checkout -b fix/foo-stable25
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
/backport to stable27 |
/backport to stable26 |
/backport to stable25 |
Fingers crossed you have better luck than me :) |
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
The backport to stable25 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable25
git pull origin stable25
# Create the new backport branch
git checkout -b fix/foo-stable25
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
1. #26813 Initial implementation with support for systemtags and davtags (vcategory) 2. #39062 Additional check if the given tag exists, though ISystemTagManager.getAllTags only looks for systemtags Therefore it's not possible anymore to search for davtags and unnecessary to join the other tables. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
1. #26813 Initial implementation with support for systemtags and davtags (vcategory) 2. #39062 Additional check if the given tag exists, though ISystemTagManager.getAllTags only looks for systemtags Therefore it's not possible anymore to search for davtags and unnecessary to join the other tables. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
1. #26813 Initial implementation with support for systemtags and davtags (vcategory) 2. #39062 Additional check if the given tag exists, though ISystemTagManager.getAllTags only looks for systemtags Therefore it's not possible anymore to search for davtags and unnecessary to join the other tables. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
1. #26813 Initial implementation with support for systemtags and davtags (vcategory) 2. #39062 Additional check if the given tag exists, though ISystemTagManager.getAllTags only looks for systemtags Therefore it's not possible anymore to search for davtags and unnecessary to join the other tables. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
1. #26813 Initial implementation with support for systemtags and davtags (vcategory) 2. #39062 Additional check if the given tag exists, though ISystemTagManager.getAllTags only looks for systemtags Therefore it's not possible anymore to search for davtags and unnecessary to join the other tables. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
1. #26813 Initial implementation with support for systemtags and davtags (vcategory) 2. #39062 Additional check if the given tag exists, though ISystemTagManager.getAllTags only looks for systemtags Therefore it's not possible anymore to search for davtags and unnecessary to join the other tables. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
1. #26813 Initial implementation with support for systemtags and davtags (vcategory) 2. #39062 Additional check if the given tag exists, though ISystemTagManager.getAllTags only looks for systemtags Therefore it's not possible anymore to search for davtags and unnecessary to join the other tables. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
1. #26813 Initial implementation with support for systemtags and davtags (vcategory) 2. #39062 Additional check if the given tag exists, though ISystemTagManager.getAllTags only looks for systemtags Therefore it's not possible anymore to search for davtags and unnecessary to join the other tables. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
1. nextcloud#26813 Initial implementation with support for systemtags and davtags (vcategory) 2. nextcloud#39062 Additional check if the given tag exists, though ISystemTagManager.getAllTags only looks for systemtags Therefore it's not possible anymore to search for davtags and unnecessary to join the other tables. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
1. #26813 Initial implementation with support for systemtags and davtags (vcategory) 2. #39062 Additional check if the given tag exists, though ISystemTagManager.getAllTags only looks for systemtags Therefore it's not possible anymore to search for davtags and unnecessary to join the other tables. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
1. nextcloud#26813 Initial implementation with support for systemtags and davtags (vcategory) 2. nextcloud#39062 Additional check if the given tag exists, though ISystemTagManager.getAllTags only looks for systemtags Therefore it's not possible anymore to search for davtags and unnecessary to join the other tables. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Summary
Avoids running a full files search if no tag matches in the first place.
Checklist