Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC][OC\Files]: Support QingStor Object Storage #3910

Closed

Conversation

Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented Mar 18, 2017

QingStor Object Storage provides low-cost and reliable online
storage service with unlimited storage space, high read and
write performance, high reliability and data safety, fine-grained
access control, and easy to use API.

This commit will allow nextcloud users to use QingStor Object
Storage as primary storage. And it's a RFC so far, because unit
test, external storage support have not been added.

Signed-off-by: Xuanwo xuanwo@yunify.com

QingStor Object Storage provides low-cost and reliable online
storage service with unlimited storage space, high read and
write performance, high reliability and data safety, fine-grained
access control, and easy to use API.

This commit will allow nextcloud users to use QingStor Object
Storage as primary storage. And it's a RFC so far, because unit
test, external storage support have not been added.

Signed-off-by: Xuanwo <xuanwo@yunify.com>
Xuanwo added a commit to Xuanwo/3rdparty that referenced this pull request Mar 18, 2017
QingStor Object Storage provides low-cost and reliable online
storage service with unlimited storage space, high read and
write performance, high reliability and data safety, fine-grained
access control, and easy to use API.

This commit will allow nextcloud users to use QingStor Object
Storage as primary storage. And it's a RFC so far, because unit
test, external storage support have not been added.

Signed-off-by: Xuanwo <xuanwo@yunify.com>

required by nextcloud/server#3910
Copy link
Member

@LukasReschke LukasReschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your change request. Generally speaking, can you give us any numbers about the distribution of QingStor? Unless this is really widely used I feel that this should rather be implemented in a dedicated app instead of added to the core.

@Xuanwo
Copy link
Contributor Author

Xuanwo commented Mar 18, 2017

QingStor is the Object Storage service provided by QingCloud , which is one of the most popular cloud service provider in China, it has been in public service for over a year, and it's still growing fast. Besides, we also provide QingStor as on-premise service.
And we are going to publish AppCenter 2.0 service very soon, AppCenter 2.0 is the application (PaaS/SaaS) framework for QingCloud like AppStore for iOS. We will provide nextcloud as one of the apps in the AppCenter 2.0 platform with no charge on the service itself, instead, we only charge for the resource, e.g. the virtual machine.
From our p.o.v, having the patch merged in will be good for either QingCloud and Nextcloud community, we are looking forward to have the patch merged in.

@MorrisJobke
Copy link
Member

I would also go for a dedicated app, because this would bring 19k new lines of code into the core and we want to slim it down.

@rullzer @icewind1991 Is it possible to do this as an app?

@osier
Copy link

osier commented Mar 20, 2017

Hi, @MorrisJobke

What we want is the NextCloud app running on QingCloud AppCenter uses QingStor bucket as the storage backend without configuration, will doing it as an app archieve the goal ?


osier at qingcloud.com

@rullzer
Copy link
Member

rullzer commented Mar 20, 2017

should (tm) be possible to do as app. Or else we should invest some resources to make it so. @icewind1991 should know more.

@icewind1991
Copy link
Member

I agree that this should be created as a separate app.

Since the objectstore class is directly referenced in the config no separate logic should be needed to register an app provided backend.

The easiest way to automatically have a hosted Nc instance use the object store would be to pre-seed objectstore configuration for a new instance.

@rullzer
Copy link
Member

rullzer commented Apr 4, 2017

Ok so lets do this as an app. As it keeps the server slimmer and allows for easier updating of the app.

@Xuanwo would you be able to create a first draft of the app?
Feel free to ping @icewind1991 and/or me for feedback. Or join irc for a chat

@rullzer rullzer closed this Apr 4, 2017
@Xuanwo
Copy link
Contributor Author

Xuanwo commented Apr 5, 2017

@rullzer I'll have a try.

@Xuanwo Xuanwo mentioned this pull request Apr 25, 2017
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants