-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
user_status: Add OpenAPI spec #39133
Conversation
@nickvergessen I agree with your points, we could try to keep 100% compatibility but then we have a pretty bad API documentation (only because of the current API of course). The changes are only done to make the API more sensible and easier to use. I'm also pretty sure this breaking change might impact nothing because clients probably ignore the content already |
My point is more that this here is a sample. All kind of apps and app devs will adjust to this sample behaviour and break any of their APIs where they use |
So are you arguing for or against this breakage? I'm not really sure what you are telling me. As I said I can also remove the compatibility break, but then we stay with this ugly API. Maybe this should be discussed differently, because I only want to document the current state and not improve it (but it happened to me many times that I saw a bad API and tried to fix it) |
Ok I will restore compatibility and type the value as |
I'm always against breaking APIs if it is not necessary.
End of July?
Thanks, sounds good 👍🏼 |
Signed-off-by: jld3103 <jld3103yt@gmail.com>
f470030
to
6f9cf88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷🏼
Summary
From #36666. Adds the necessary annotations and descriptions.
Checklist