Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor admin audit app #39192

Closed
wants to merge 9 commits into from
Closed

Refactor admin audit app #39192

wants to merge 9 commits into from
+347 −284

Commits on Oct 10, 2023

  1. Revert condition to iterate early in the loop 

    Signed-off-by: Danial Rahimi <48244647+danialRahimy@users.noreply.github.com>
    @danialRahimy
    danialRahimy committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    7974ab4 View commit details
    Browse the repository at this point in the history

  2. Extract codes to separate methods to more readability 

    Signed-off-by: Danial Rahimi <48244647+danialRahimy@users.noreply.github.com>
    @danialRahimy
    danialRahimy committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    202906a View commit details
    Browse the repository at this point in the history

  3. Replace conditions with match expression according to php8 

    Signed-off-by: Danial Rahimi <48244647+danialRahimy@users.noreply.github.com>
    @danialRahimy
    danialRahimy committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    e17c223 View commit details
    Browse the repository at this point in the history

  4. Declare methods return types 

    Signed-off-by: Danial Rahimi <48244647+danialRahimy@users.noreply.github.com>
    @danialRahimy
    danialRahimy committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    9a51a0d View commit details
    Browse the repository at this point in the history

  5. Add properties type 

    Signed-off-by: Danial Rahimi <48244647+danialRahimy@users.noreply.github.com>
    @danialRahimy
    danialRahimy committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    b06913d View commit details
    Browse the repository at this point in the history

  6. Run php-cs-fixer 

    Signed-off-by: Danial Rahimi <48244647+danialRahimy@users.noreply.github.com>
    @danialRahimy
    danialRahimy committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    47e4add View commit details
    Browse the repository at this point in the history

  7. Remove property type to fix psalm error 

    Signed-off-by: Danial Rahimi <48244647+danialRahimy@users.noreply.github.com>
    @danialRahimy
    danialRahimy committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    009983e View commit details
    Browse the repository at this point in the history

  8. Update apps/admin_audit/lib/AuditLogger.php 

    Co-authored-by: Benjamin Gaussorgues <github-fa3ie@altahrim.net>
Signed-off-by: danial rahimy <48244647+danialRahimy@users.noreply.github.com>
    @danialRahimy @Altahrim
    danialRahimy and Altahrim committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    b01dd7c View commit details
    Browse the repository at this point in the history

  9. Updated array usage from array() to [] for improved code readability … 

    …and modern syntax.

Signed-off-by: Danial Rahimi <48244647+danialRahimy@users.noreply.github.com>
    @danialRahimy
    danialRahimy committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    5db849f View commit details
    Browse the repository at this point in the history