fix(a11y): Files table roles #39385
Closed
fix(a11y): Files table roles #39385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
|
/backport to stable27 |
Files2Vue a11y so would call this a followup to #36534 |
JuliaKirschenheuter
approved these changes
Jul 24, 2023
skjnldsv
requested changes
Aug 2, 2023
| @@ -23,7 +23,7 @@ | |||
| <NcAppContent v-show="!currentView?.legacy" | |||
| :class="{'app-content--hidden': currentView?.legacy}" | |||
| data-cy-files-content> | |||
| <div class="files-list__header"> | |||
| <div class="files-list__crumbs"> | |||
There was a problem hiding this comment.
Please no, more things than breadcrumbs are/will-be in here
| @@ -143,8 +143,10 @@ export default Vue.extend({ | |||
| mounted() { | |||
| // Make the root recycle scroller a table for proper semantics | |||
| const slots = this.$el.querySelectorAll('.vue-recycle-scroller__slot') | |||
| slots[0].setAttribute('role', 'thead') | |||
There was a problem hiding this comment.
Why is the thead not needed anymore suddenly?
The first table tr row is exactly a header, no?
https://developer.mozilla.org/en-US/docs/Learn/HTML/Tables/Advanced#the_scope_attribute
|
Superseded by #39808 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist