Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't emit Hooks when hookpaths are empty #39481

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Jul 19, 2023

Summary

Fixes Transferring ownership issues when not using OCC command but GUI.

Checklist

@miaulalala miaulalala added bug 3. to review Waiting for reviews labels Jul 19, 2023
@miaulalala miaulalala added this to the Nextcloud 28 milestone Jul 19, 2023
@miaulalala miaulalala self-assigned this Jul 19, 2023
@miaulalala
Copy link
Contributor Author

/backport to stable27

@miaulalala
Copy link
Contributor Author

/backport to stable26

@miaulalala
Copy link
Contributor Author

/backport to stable25

@miaulalala

This comment was marked as resolved.

@miaulalala miaulalala marked this pull request as draft July 19, 2023 15:20
@blizzz

This comment was marked as outdated.

@miaulalala

This comment was marked as outdated.

@solracsf

This comment was marked as outdated.

Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala force-pushed the fix/transfer-ownersip branch from f3e8a10 to 556f29b Compare August 17, 2023 07:32
@miaulalala miaulalala marked this pull request as ready for review August 17, 2023 07:35
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 17, 2023
@miaulalala
Copy link
Contributor Author

Drone failure unrelated:

Scenario: Browse disabled apps                           # /drone/src/tests/acceptance/features/apps.feature:26
--
143 | Given I act as Jane                                    # ActorContext::iActAs()
144 | And I am logged in as the admin                        # LoginPageContext::iAmLoggedInAsTheAdmin()
145 | And I open the Apps management                         # SettingsMenuContext::iOpenTheAppsManagement()
146 | When I open the "Disabled apps" section                # AppNavigationContext::iOpenTheSection()
147 | Then I see that the current section is "Disabled apps" # AppNavigationContext::iSeeThatTheCurrentSectionIs()
148 | And I see that there are only disabled apps            # AppsManagementContext::iSeeThatThereAreOnlyDisabledApps()
149 | Found enabled apps


┌─ @BeforeScenario # ActorContext::initializeActors()
--
209 | │
210 | ╳  Could not open connection: unknown error: Chrome failed to start: exited abnormally.
211 | ╳    (unknown error: DevToolsActivePort file doesn't exist)
212 | ╳    (The process started from chrome location /usr/bin/google-chrome is no longer running, so ChromeDriver is assuming that Chrome has crashed.)
213 | ╳    (Driver info: chromedriver=90.0.4430.24 (4c6d850f087da467d926e8eddb76550aed655991-refs/branch-heads/4430@{#429}),platform=Linux 5.4.0-126-generic x86_64) (WARNING: The server did not provide any stacktrace information)
214 | ╳  Command duration or timeout: 364 milliseconds
215 | ╳  Build info: version: '3.141.59', revision: 'e82be7d358', time: '2018-11-14T08:25:53'
216 | ╳  System info: host: '970305e75525', ip: '172.23.0.2', os.name: 'Linux', os.arch: 'amd64', os.version: '5.4.0-126-generic', java.version: '1.8.0_282'
217 | ╳  Driver info: driver.version: unknown (Behat\Mink\Exception\DriverException)
218 | │

@max-nextcloud
Copy link
Contributor

Tested locally and worked... as soon as i had the notifcations app installed ☺️

@juliusknorr juliusknorr merged commit 45595a8 into master Aug 17, 2023
@juliusknorr juliusknorr deleted the fix/transfer-ownersip branch August 17, 2023 11:23
@backportbot-nextcloud

This comment was marked as resolved.

@backportbot-nextcloud

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
8 participants