-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(notifications): Remove share notification when the node is deleted #39689
fix(notifications): Remove share notification when the node is deleted #39689
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
/backport to stable27 |
/backport to stable26 |
/backport to stable25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means that deleting a file does not delete shares related to it? (since here the share exists but not the file)
Corollary: What will happen to this share which was never accepted and for which notification was removed, will it live on forever in database? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on web client, now behavior is aligned with unsharing - notification dismisses after file is deleted
There is a 15min background job:
And a custom command:
But the 15min could be enough time to cause confusion.
Yes, the "pending shares" view still allows accepting it |
Why is that not done through a listener of the deletion event instead? (or on top of) |
We'd need to loop over all subfolders and files, potentially thousands to millions |
Steps
Optional: Set up a mobile app for better testing
As UserA go to index.php/settings/user/sharing and disable the checkbox
As UserB create a folder and share it to UserA
As UserA reload the page or refresh the notifications on the mobile app, so you see the share notification
As UserB delete the the folder from 3.
As UserA repeat 4.
Expected
No notification anymore
Actual
Notification was still visible and "Decline" yields an error
Checklist