Refactor OC\Server::getContactsManager
#40119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
summersab
force-pushed
the
refactor/OC-Server-getContactsManager
branch
from
507bc6e to
bc069d0
Compare
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
summersab
force-pushed
the
refactor/OC-Server-getContactsManager
branch
from
bc069d0 to
29d70d6
Compare
|
Just commenting to ask if someone could re-run the GitHub actions on this one. Thanks! |
Merged
This was referenced Mar 12, 2024
Merged
Merged
Merged
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
skjnldsv
requested review from
artonge,
come-nc,
a team and
sorbaugh
and removed request for
a team
artonge
approved these changes
May 30, 2024
susnux
approved these changes
May 30, 2024
skjnldsv
added
4. to release
come-nc
reviewed
May 30, 2024
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the deprecated method
OC\Server::getContactsManagerand replaces it withOC\Server::get(\OCP\Contacts\IManager::class)throughout the entire NC codebase (excluding./appsand./3rdparty).Additionally, where necessary, the
\OCP\Contacts\IManagerclass is imported via theusedirective.