Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make public links work with master key #4030

Merged
merged 3 commits into from
Apr 4, 2017
Merged

Conversation

schiessle
Copy link
Member

@schiessle schiessle commented Mar 24, 2017

Make master key work for public links

fix for owncloud/core#27261

Steps to test:

  1. setup nextcloud
  2. occ app:enable encryption
  3. occ encryption:enable
  4. occ encryption:enable-master-key, answer yes
  5. Create a user "user1"
  6. Login as "user1"
  7. Create a file "bacon.txt"
  8. Share "bacon.txt" with link
  9. Log out
  10. Open link
  11. Download file

@nextcloud/encryption

Vincent Petry added 3 commits March 24, 2017 14:55
In public link mode there is no session, so the code should use the
public key instead.
@mention-bot
Copy link

@schiessle, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @nickvergessen and @rullzer to be potential reviewers.

@schiessle schiessle changed the title Masterkey publiclink nc12 Make public links work with master key Mar 24, 2017
@rullzer rullzer added the 3. to review Waiting for reviews label Apr 4, 2017
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@rullzer rullzer merged commit da178db into master Apr 4, 2017
@rullzer rullzer deleted the masterkey-publiclink-nc12 branch April 4, 2017 09:46
@schiessle
Copy link
Member Author

for 11.0.3: #4207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants