feat: update sign up link in share pages #40368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
reviewed
Sep 11, 2023
juliusknorr
reviewed
Sep 11, 2023
juliusknorr
requested changes
Sep 11, 2023
luka-nextcloud
force-pushed
the
feature/update-signup-link
branch
2 times, most recently
from
239ab00 to
e92d396
Compare
juliusknorr
approved these changes
Sep 15, 2023
juliusknorr
requested review from
a team,
ArtificialOwl,
icewind1991 and
sorbaugh
and removed request for
a team
icewind1991
reviewed
Sep 17, 2023
juliusknorr
force-pushed
the
feature/update-signup-link
branch
from
e92d396 to
61acb49
Compare
juliusknorr
requested review from
Altahrim and
mejo-
and removed request for
max-nextcloud
Altahrim
approved these changes
Oct 31, 2023
lib/private/TemplateLayout.php
Outdated
| @@ -199,7 +201,21 @@ public function __construct($renderAs, $appId = '') { | |||
| if ($showSimpleSignup && $subscription->delegateHasValidSubscription()) { | |||
| $showSimpleSignup = false; | |||
| } | |||
|
|
|||
| $urlGenerator = \OCP\Server::get(IURLGenerator::class); | |||
There was a problem hiding this comment.
I think we can put this line within the if condition line 213
Merged
Merged
luka-nextcloud
force-pushed
the
feature/update-signup-link
branch
from
61acb49 to
15c26ec
Compare
Signed-off-by: Luka Trovic <luka@nextcloud.com>
luka-nextcloud
force-pushed
the
feature/update-signup-link
branch
from
15c26ec to
b134e1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist