refactor: Replace array_search with in_array in lib/ #40462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
requested review from
nickvergessen,
st3iny,
Altahrim,
kesselb and
come-nc
st3iny
approved these changes
Sep 17, 2023
tcitworld
approved these changes
Sep 17, 2023
Altahrim
approved these changes
Sep 18, 2023
|
CI failure is unrelated as far as I can tell |
ChristophWurst
added
4. to release
nickvergessen
approved these changes
Sep 19, 2023
| @@ -269,7 +269,7 @@ public function extract(string $dest): bool { | |||
| */ | |||
| public function fileExists(string $path): bool { | |||
| $files = $this->getFiles(); | |||
| if ((array_search($path, $files) !== false) or (array_search($path . '/', $files) !== false)) { | |||
| if ((in_array($path, $files)) or (in_array($path . '/', $files))) { | |||
There was a problem hiding this comment.
Suggested change
| if ((in_array($path, $files)) or (in_array($path . '/', $files))) { | |
| if (in_array($path, $files) || in_array($path . '/', $files)) { |
There was a problem hiding this comment.
I can address that syntax in another PR 👍
|
Failing samba tests could be related to touching |
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
blizzz
force-pushed
the
refactor/lib-array_search-to-in_array
branch
from
4fd113a
to
ea8f9a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
in_arrayreturnsbool, therefore the syntax is more compact than the comparison withfalseforarray_search.Checklist