Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Inform user about master key generation on encryption enabling #40468

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

func0der
Copy link
Contributor

@func0der func0der commented Sep 17, 2023

Summary

The user/admin should be informed about the fact that the encryption is generating a master key for the whole instance.
This default behavior was introduced in Nextcloud 13 and was not properly communicated (as it seems). There was no trace to be found in the docs, nor was there anything in the interface warning the non-RTFM users about this.

This change to a less secure, but more user friendly setup, should be clearly communicated to the user since Nextcloud is used in more and more setups which require them to be compliant with very high privacy standards.
If the user is not pro-actively informed about this setup, they might violate those standards by accident.

TODO

  • Add language file entries for all languages (done when this change finds acceptance)

Checklist

Before After
before after

@joshtrichards
Copy link
Member

Hi @func0der - Thanks for working on this and giving some thought to the user experience side! I also saw your directly related PR for the docs (nextcloud/documentation#11122).

There are a handful of outstanding/overlapping server-side encryption Issues/PRs in the docs section right now, some of which directly touch this matter (https://github.com/nextcloud/documentation/labels/feature%3A%20encryption%20%28server-side%29)

Here's what I suggest:

  • Let's see if we can use your recent PR in the docs repo to finally clean up the server-side encryption documentation a bit (in this particular area at least)
  • Once the docs are clear(er), let's see bring some of it's language into this PR and/or reference it

I'll also try to consolidate some of the duplicate Issues in the docs repo that cover this topic.

@joshtrichards joshtrichards added the pending documentation This pull request needs an associated documentation update label Oct 27, 2023
@func0der
Copy link
Contributor Author

Anything that clears this matter up is a welcome change :D

@solracsf solracsf added this to the Nextcloud 28 milestone Nov 21, 2023
@blizzz blizzz mentioned this pull request Nov 22, 2023
5 tasks
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@skjnldsv skjnldsv added the 2. developing Work in progress label Feb 21, 2024
This was referenced Mar 12, 2024
This was referenced Mar 20, 2024
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
81 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
This was referenced Jul 30, 2024
This was referenced Aug 5, 2024
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
@skjnldsv skjnldsv added this to the Nextcloud 32 milestone Jan 30, 2025
@susnux susnux requested review from artonge and szaimen January 31, 2025 15:56
@szaimen
Copy link
Contributor

szaimen commented Jan 31, 2025

Hm... wouldnt this conflict with #50424?

@susnux
Copy link
Contributor

susnux commented Jan 31, 2025

@szaimen yes but that information is still there and we should add that part

@susnux
Copy link
Contributor

susnux commented Jan 31, 2025

@func0der took the liberty to rebase the PR

@susnux susnux requested a review from a team as a code owner March 5, 2025 15:35
@susnux susnux requested review from susnux and removed request for a team March 5, 2025 15:35
@susnux susnux added 3. to review Waiting for reviews enhancement and removed 2. developing Work in progress pending documentation This pull request needs an associated documentation update labels Mar 5, 2025
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@AndyScherzinger
Copy link
Member

/compile /

func0der and others added 2 commits March 5, 2025 18:08
…n enabling

Signed-off-by: func0der <529819+func0der@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
Copy link
Contributor

susnux commented Mar 5, 2025

@AndyScherzinger compile does not work on forks. Manually compiled and pushed.
Cypress is disabled on forks too but there should be no issue as this is only adding text (and we do not even have tests for it).

@AndyScherzinger AndyScherzinger merged commit 5509c84 into nextcloud:master Mar 5, 2025
108 of 111 checks passed
Copy link

welcome bot commented Mar 5, 2025

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@AndyScherzinger
Copy link
Member

Thanks for the compile @susnux and thanks a lot for the contribution @func0der 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants