Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable26] SFTP improvements #40521

Merged
merged 10 commits into from
Dec 7, 2023
Merged

[stable26] SFTP improvements #40521

merged 10 commits into from
Dec 7, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #40487

use phpseclib\Net\SFTP\Stream;

/**
* Uses phpseclib's Net\SFTP class and the Net\SFTP\Stream stream wrapper to
* provide access to SFTP servers.
*/
class SFTP extends \OC\Files\Storage\Common {
class SFTP extends Common {

Check notice

Code scanning / Psalm

DeprecatedInterface Note

OCP\Files\Storage is marked deprecated
apps/files_external/lib/Lib/Storage/SFTP.php Fixed Show fixed Hide fixed
apps/files_external/lib/Lib/Storage/SFTP.php Fixed Show fixed Hide fixed
}
}

public function copy($source, $target) {

Check notice

Code scanning / Psalm

MissingParamType Note

Parameter $source has no provided type
This was referenced Sep 20, 2023
@solracsf solracsf changed the title [stable26] [stable27] SFTP improvements [stable26] SFTP improvements Sep 21, 2023
@solracsf solracsf added the 3. to review Waiting for reviews label Oct 3, 2023
@blizzz blizzz mentioned this pull request Oct 9, 2023
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
@blizzz blizzz force-pushed the backport/40487/stable26 branch from bc79ff1 to 22237b0 Compare October 10, 2023 07:12
@blizzz blizzz added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 10, 2023
@blizzz blizzz mentioned this pull request Nov 13, 2023
@blizzz blizzz requested review from artonge and come-nc November 15, 2023 20:33
@blizzz blizzz requested a review from icewind1991 November 15, 2023 20:33
@blizzz
Copy link
Member

blizzz commented Nov 16, 2023

moving to 26.0.10

@blizzz blizzz mentioned this pull request Dec 4, 2023
@blizzz
Copy link
Member

blizzz commented Dec 4, 2023

CI is dissatisfied

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
Copy link
Member

fixed psalm (kerberos test is known broken in 26 and node seems unrelated)

@blizzz blizzz merged commit 373e3ae into stable26 Dec 7, 2023
47 of 50 checks passed
@blizzz blizzz deleted the backport/40487/stable26 branch December 7, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants