-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding dav resource for avatars #4062
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
23aab05
Adding dav resource for avatars
DeepDiver1975 7300725
Return last modification time to allow proper listing in cadaver
DeepDiver1975 3e93f49
Adding AvatarHomeTest
DeepDiver1975 836271e
Adding AvatarNodeTest
DeepDiver1975 f0850b2
Fix inspection results
rullzer 2a77727
Fix PHPDoc
LukasReschke 7cc96c2
Don't output jpeg if we request png
rullzer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,120 @@ | ||
<?php | ||
/** | ||
* @author Thomas Müller <thomas.mueller@tmit.eu> | ||
* | ||
* @copyright Copyright (c) 2016, ownCloud GmbH | ||
* @license AGPL-3.0 | ||
* | ||
* This code is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU Affero General Public License, version 3, | ||
* as published by the Free Software Foundation. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU Affero General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU Affero General Public License, version 3, | ||
* along with this program. If not, see <http://www.gnu.org/licenses/> | ||
* | ||
*/ | ||
|
||
|
||
namespace OCA\DAV\Avatars; | ||
|
||
|
||
use OCP\IAvatarManager; | ||
use Sabre\DAV\Exception\Forbidden; | ||
use Sabre\DAV\Exception\MethodNotAllowed; | ||
use Sabre\DAV\Exception\NotFound; | ||
use Sabre\DAV\ICollection; | ||
use Sabre\Uri; | ||
|
||
class AvatarHome implements ICollection { | ||
|
||
/** @var array */ | ||
private $principalInfo; | ||
/** @var IAvatarManager */ | ||
private $avatarManager; | ||
|
||
/** | ||
* AvatarHome constructor. | ||
* | ||
* @param array $principalInfo | ||
* @param IAvatarManager $avatarManager | ||
*/ | ||
public function __construct($principalInfo, IAvatarManager $avatarManager) { | ||
$this->principalInfo = $principalInfo; | ||
$this->avatarManager = $avatarManager; | ||
} | ||
|
||
public function createFile($name, $data = null) { | ||
throw new Forbidden('Permission denied to create a file'); | ||
} | ||
|
||
public function createDirectory($name) { | ||
throw new Forbidden('Permission denied to create a folder'); | ||
} | ||
|
||
public function getChild($name) { | ||
$elements = pathinfo($name); | ||
$ext = isset($elements['extension']) ? $elements['extension'] : ''; | ||
$size = (int)(isset($elements['filename']) ? $elements['filename'] : '64'); | ||
if (!in_array($ext, ['jpeg', 'png'], true)) { | ||
throw new MethodNotAllowed('File format not allowed'); | ||
} | ||
if ($size <= 0 || $size > 1024) { | ||
throw new MethodNotAllowed('Invalid image size'); | ||
} | ||
$avatar = $this->avatarManager->getAvatar($this->getName()); | ||
if ($avatar === null || !$avatar->exists()) { | ||
throw new NotFound(); | ||
} | ||
return new AvatarNode($size, $ext, $avatar); | ||
} | ||
|
||
public function getChildren() { | ||
try { | ||
return [ | ||
$this->getChild('96.jpeg') | ||
]; | ||
} catch(NotFound $exception) { | ||
return []; | ||
} | ||
} | ||
|
||
public function childExists($name) { | ||
try { | ||
$ret = $this->getChild($name); | ||
return $ret !== null; | ||
} catch (NotFound $ex) { | ||
return false; | ||
} catch (MethodNotAllowed $ex) { | ||
return false; | ||
} | ||
} | ||
|
||
public function delete() { | ||
throw new Forbidden('Permission denied to delete this folder'); | ||
} | ||
|
||
public function getName() { | ||
list(,$name) = Uri\split($this->principalInfo['uri']); | ||
return $name; | ||
} | ||
|
||
public function setName($name) { | ||
throw new Forbidden('Permission denied to rename this folder'); | ||
} | ||
|
||
/** | ||
* Returns the last modification time, as a unix timestamp | ||
* | ||
* @return int|null | ||
*/ | ||
public function getLastModified() { | ||
return null; | ||
} | ||
|
||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,98 @@ | ||
<?php | ||
/** | ||
* @author Thomas Müller <thomas.mueller@tmit.eu> | ||
* | ||
* @copyright Copyright (c) 2016, ownCloud GmbH | ||
* @license AGPL-3.0 | ||
* | ||
* This code is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU Affero General Public License, version 3, | ||
* as published by the Free Software Foundation. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU Affero General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU Affero General Public License, version 3, | ||
* along with this program. If not, see <http://www.gnu.org/licenses/> | ||
* | ||
*/ | ||
|
||
|
||
namespace OCA\DAV\Avatars; | ||
|
||
|
||
use OCP\IAvatar; | ||
use Sabre\DAV\File; | ||
|
||
class AvatarNode extends File { | ||
private $ext; | ||
private $size; | ||
private $avatar; | ||
|
||
/** | ||
* AvatarNode constructor. | ||
* | ||
* @param integer $size | ||
* @param string $ext | ||
* @param IAvatar $avatar | ||
*/ | ||
public function __construct($size, $ext, $avatar) { | ||
$this->size = $size; | ||
$this->ext = $ext; | ||
$this->avatar = $avatar; | ||
} | ||
|
||
/** | ||
* Returns the name of the node. | ||
* | ||
* This is used to generate the url. | ||
* | ||
* @return string | ||
*/ | ||
public function getName() { | ||
return "$this->size.$this->ext"; | ||
} | ||
|
||
public function get() { | ||
$image = $this->avatar->get($this->size); | ||
$res = $image->resource(); | ||
|
||
ob_start(); | ||
if ($this->ext === 'png') { | ||
imagepng($res); | ||
} else { | ||
imagejpeg($res); | ||
} | ||
|
||
return ob_get_clean(); | ||
} | ||
|
||
/** | ||
* Returns the mime-type for a file | ||
* | ||
* If null is returned, we'll assume application/octet-stream | ||
* | ||
* @return string|null | ||
*/ | ||
public function getContentType() { | ||
if ($this->ext === 'png') { | ||
return 'image/png'; | ||
} | ||
return 'image/jpeg'; | ||
} | ||
|
||
public function getETag() { | ||
return $this->avatar->getFile($this->size)->getEtag(); | ||
} | ||
|
||
public function getLastModified() { | ||
$timestamp = $this->avatar->getFile($this->size)->getMTime(); | ||
if (!empty($timestamp)) { | ||
return (int)$timestamp; | ||
} | ||
return $timestamp; | ||
|
||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
<?php | ||
|
||
namespace OCA\DAV\Avatars; | ||
|
||
use Sabre\DAVACL\AbstractPrincipalCollection; | ||
|
||
|
||
class RootCollection extends AbstractPrincipalCollection { | ||
|
||
/** | ||
* This method returns a node for a principal. | ||
* | ||
* The passed array contains principal information, and is guaranteed to | ||
* at least contain a uri item. Other properties may or may not be | ||
* supplied by the authentication backend. | ||
* | ||
* @param array $principalInfo | ||
* @return AvatarHome | ||
*/ | ||
public function getChildForPrincipal(array $principalInfo) { | ||
$avatarManager = \OC::$server->getAvatarManager(); | ||
return new AvatarHome($principalInfo, $avatarManager); | ||
} | ||
|
||
public function getName() { | ||
return 'avatars'; | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this as it gets an image. Instead of just a file...