[stable27] fix(files): service worker

[SuperSandro2000]

This is a partial backport of 3344f0f

• Resolves: [Bug]: Content Security Policy (CSP) Error for preview-service-worker.js #39849 for stable 27

Summary

Backports a fix which allows the service worker of the files app to be reigstered

Refused to create a worker from 'https://nextcloud.mydomain.de/index.php/apps/files/preview-service-worker.js' because it violates the following Content Security Policy directive: "script-src 'nonce-aFNJRWFwcklWUlMvTVM5WDZxdnBtOEtyeWh4OVpzbHBGckh3NkpGeHk4OD06L0c1OEJOU0RiRk9IYVg1OGpzN2NycnZoa2xrZU51WWhmY216M3ZNMHVKaz0='". Note that 'worker-src' was not explicitly set, so 'script-src' is used as a fallback.

I deployed this on my server with NixOS and the error is gone and the networks tab showed that the service worker is being used. Since I am using h3/h2 the difference was not noticeable.

TODO

• ...

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[SuperSandro2000]

Not sure why the tests fail. I wouldn't expect this to have such big impact.

[skjnldsv]

• Cypress fails because your fork stable27 branch is not up-to-date
• Drone fails because

   There was 1 failure:
   294 |  
   295 | 1) OCA\Files\Tests\Controller\ViewControllerTest::testIndexWithRegularBrowser
   296 | Failed asserting that two objects are equal.
   297 | --- Expected
   298 | +++ Actual
   299 | @@ @@
   300 | 'allowedChildSrcDomains' => Array ()
   301 | 'allowedFrameAncestors' => Array (...)
   302 | 'allowedWorkerSrcDomains' => Array (
   303 | +            0 => ''self''
   304 | )
   305 | 'allowedFormActionDomains' => Array (...)
   306 | 'reportTo' => Array ()
   307 |  
   308 | /drone/src/apps/files/tests/Controller/ViewControllerTest.php:419
  

• Block merges during freezes fails because stable27 is in RC2, and therefore in feature freeze until next Thursday where final releases will be built :)

[SuperSandro2000]

• Cypress fails because your fork stable27 branch is not up-to-date

I've based this branch onto the main repos stable27 branch and just rebased it again and there were no changes.

• Drone fails because

ammended that and ran the test locally which succeeded now.

[Pytal]

Cypress seems related

[SuperSandro2000]

I am not sure how the errors are related to cypress. There seems to be a lot of errors because something with the filesystem is off, probably it is full or inodes ran out and most tests seem to fail with 503 which shouldn't happen based on my change.

[skjnldsv]

@SuperSandro2000 your master branch is not up to date with our master branch, cypress is therefore failing. Please also rebase this branch to master

[SuperSandro2000]

Just did that. It's sometimes a bit confusing from where github actions are being taken.

[SuperSandro2000]

Still doesn't work and I frankly don't really have the time to debug why cypress is misbehaving. Can't you just cherry-pick this trivial fix otherwise we might as well wait for 28.0.0.

[nickvergessen]

It's sometimes a bit confusing from where github actions are being taken.

Administrators had to approve the run. Did that now

[nickvergessen]

Performance testing / performance-8.0

Doesn't work on forks, should be fine.
Cypress I can't judge

[blizzz]

moving to 27.1.5

[SuperSandro2000]

I have no idea why Cypress doesn't work and I inclined to just close this. I locally fixed this with a NixOS overlay.

[blizzz]

moving to 27.1.6

[solracsf]

Cleaner version at #42608