Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(a11y): Increase contrast of contacts menu actions #41207

Merged
merged 2 commits into from
Oct 31, 2023
Merged

fix(a11y): Increase contrast of contacts menu actions #41207

merged 2 commits into from
Oct 31, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Oct 31, 2023

Summary

Before After
image image

Checklist

Pytal added 2 commits October 30, 2023 17:10
@Pytal
fix(a11y): Increase contrast of contacts menu actions
5dd61b5 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore: compile assets
4dbef5b 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added this to the Nextcloud 28 milestone Oct 31, 2023
@Pytal Pytal self-assigned this Oct 31, 2023
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 31, 2023
@ChristophWurst
Copy link
Member

Will conflict with #40852. Whichever PR gets in last will need a rebase :)

@Pytal
Copy link
Member Author

Pytal commented Oct 31, 2023

Will conflict with #40852. Whichever PR gets in last will need a rebase :)

Shall quick merge this small one 🏃‍♀️ :)

@Pytal Pytal merged commit b4e7070 into master Oct 31, 2023
@Pytal Pytal deleted the fix/a11y/contacts-menu-actions branch October 31, 2023 17:53
@Pytal Pytal mentioned this pull request Oct 31, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@ShGKme ShGKme ShGKme approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility feature: contacts menu
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
4 participants
@Pytal @ChristophWurst @ShGKme @szaimen