Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable26] Show proper warning on 0 quota #41264

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Nov 3, 2023

Steps to reproduce

  • Have 0 quota configured
  • Open the file list

before

The file create menu was shown

After

A proper info is shown as it was on Nextcloud 25

Screenshot 2023-11-03 at 11 57 28

max-nextcloud and others added 2 commits November 3, 2023 11:17
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr changed the title bugfix/noid/quota 0 [stable26] Show proper warning on 0 quota Nov 3, 2023
@juliusknorr juliusknorr requested review from skjnldsv, a team, nfebe and sorbaugh and removed request for a team November 3, 2023 10:58
@juliusknorr juliusknorr added the 3. to review Waiting for reviews label Nov 3, 2023
@juliusknorr juliusknorr added the bug label Nov 3, 2023
@juliusknorr
Copy link
Member Author

f63fa8c would be worth to be ported to 27 as well

@solracsf
Copy link
Member

solracsf commented Nov 3, 2023

Why the message is not You don't have either permission or quota to upload or create files here ?

@juliusknorr
Copy link
Member Author

Something to discuss separately in an issue I'd say since we would want to change this in the master branch first anyways.

@solracsf solracsf added this to the Nextcloud 26.0.9 milestone Nov 10, 2023
@blizzz blizzz mentioned this pull request Nov 13, 2023
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@blizzz blizzz merged commit a6997c8 into stable26 Nov 15, 2023
36 of 37 checks passed
@blizzz blizzz deleted the bugfix/noid/quota-0 branch November 15, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants