feat(contactsmenu): Sort by user status #41266
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
List system contacts with a recent custom status message first sorted descending by the status change time, then all other contacts sorted ascending by their name.
If user_status is not enabled or nobody set their custom status recently, fall back to sorting by contact name ascending only.
TODO
Fix usage ofNot used anyway. API now falls back to old behavior if offset is supplied.\OCP\Contacts\ContactsMenu\IContactsStore::getContacts
with pagination(avatars are only broken because automated tests deleted them …)
Follow-up
Checklist