-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(settings): Always show "Nextcloud" before version number #41317
fix(settings): Always show "Nextcloud" before version number #41317
Conversation
Not sure if this is always wanted, cc @jancborchardt @AndyScherzinger |
@AndyScherzinger what do you think? It would make sense to show "Nextcloud" there always, but as far as I remember we did this to not confuse people when using branded versions. However this confusion specifically occurs with branded versions … |
ping @AndyScherzinger, approve or close 🧑⚖️ |
Fine to merge 👍 |
03f380a
to
8711e2f
Compare
Signed-off-by: Fabian Zwemke <fabian@zwemke.de>
8711e2f
to
6a49509
Compare
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Summary
In the Administrator Settings (Overview tab), the branded name was shown before the version number. Now, it's (always) formatted as "Nextcloud Hub 7 ".
Checklist