Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(settings): Always show "Nextcloud" before version number #41317

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

fabianzw
Copy link
Contributor

@fabianzw fabianzw commented Nov 6, 2023

Summary

In the Administrator Settings (Overview tab), the branded name was shown before the version number. Now, it's (always) formatted as "Nextcloud Hub 7 ".

Checklist

@szaimen szaimen added the 3. to review Waiting for reviews label Nov 6, 2023
@szaimen szaimen added this to the Nextcloud 28 milestone Nov 6, 2023
@szaimen szaimen requested review from a team, ArtificialOwl, icewind1991 and sorbaugh and removed request for a team November 6, 2023 22:28
@susnux
Copy link
Contributor

susnux commented Nov 6, 2023

Not sure if this is always wanted, cc @jancborchardt @AndyScherzinger

@jancborchardt
Copy link
Member

@AndyScherzinger what do you think? It would make sense to show "Nextcloud" there always, but as far as I remember we did this to not confuse people when using branded versions. However this confusion specifically occurs with branded versions …

This was referenced Nov 8, 2023
@blizzz blizzz mentioned this pull request Nov 20, 2023
5 tasks
@fabianzw
Copy link
Contributor Author

Under User Icon/About, Nextcloud uses the unbranded name alongside its version number (for both admin and normal users).
grafik

I feel like it's inconsistent to use the branded name in the administrator settings, especially when referring to the software version.
How should we proceed?

@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@skjnldsv
Copy link
Member

@AndyScherzinger what do you think? It would make sense to show "Nextcloud" there always, but as far as I remember we did this to not confuse people when using branded versions. However this confusion specifically occurs with branded versions …

ping @AndyScherzinger, approve or close 🧑‍⚖️

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 23, 2024
@AndyScherzinger
Copy link
Member

Fine to merge 👍

@AndyScherzinger AndyScherzinger force-pushed the fix/admin_overview_version branch from 03f380a to 8711e2f Compare February 27, 2024 08:33
Signed-off-by: Fabian Zwemke <fabian@zwemke.de>
@AndyScherzinger AndyScherzinger force-pushed the fix/admin_overview_version branch from 8711e2f to 6a49509 Compare February 27, 2024 09:31
@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 27, 2024
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 27, 2024
@skjnldsv skjnldsv merged commit 831a779 into nextcloud:master Feb 27, 2024
152 of 159 checks passed
Copy link

welcome bot commented Feb 27, 2024

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@fabianzw fabianzw deleted the fix/admin_overview_version branch February 27, 2024 17:14
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Admin overview displays Nextcloud version as the instance name's version
7 participants