fix(files): Do not encode the path twice (and do not use undefined method) #41329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thod) Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
|
Hum, weird. EDIT: ah, right, I left the |
skjnldsv
approved these changes
Nov 7, 2023
Pytal
approved these changes
Nov 7, 2023
Pytal
added
4. to release
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes files being not able to be moved, currently the error is "encodePath not defined" but adding
encodePathwill break as well because then file names are encoded twice, e.g. in the following example it would fail because "Neuer Ordner" would be encoded to "Neuer%20Ordner" and then to "Neuer%2520Ordner".Before
vokoscreenNG-2023-11-07_16-50-56.mp4
After
vokoscreenNG-2023-11-07_16-50-16.mp4
Checklist