Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(LDAP): prevent incomplete displaynames… #41333

Merged
merged 1 commit into from
Nov 9, 2023
Merged

fix(LDAP): prevent incomplete displaynames… #41333

merged 1 commit into from
Nov 9, 2023

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Nov 7, 2023 •
edited
Loading

… when reading users from primary groups or gidNumber-based groups

Summary

  • In cases where user information was read out from primary groups or gidNumber-based groups, displayname might be cached incompletely without their second part (provided it was configured).

Checklist

@blizzz
fix(LDAP): prevent incomplete displaynames…
d978050 
… when reading users from primary groups or gidNumber-based groups

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added this to the Nextcloud 28 milestone Nov 7, 2023
@blizzz blizzz requested review from juliusknorr, come-nc, a team, icewind1991 and nfebe and removed request for a team November 7, 2023 20:06
@blizzz
Copy link
Member Author

blizzz commented Nov 7, 2023

/backport to stable27

@blizzz
Copy link
Member Author

blizzz commented Nov 7, 2023

/backport to stable26

@blizzz blizzz mentioned this pull request Nov 8, 2023
Merged
@blizzz blizzz merged commit 743066a into master Nov 9, 2023
47 of 50 checks passed
@blizzz blizzz deleted the fix/41316/incomplete-displayname branch November 9, 2023 19:41
This was referenced Nov 9, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: ldap
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

[Bug]: LDAP's second display name part is being forgotten
3 participants
@blizzz @juliusknorr @come-nc