Replace ActionLink with ActionButton on sharing tab #41580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com> So-authored-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/a11y-replace_action_link_with_action_button
branch
from
304945f
to
ff2ef8d
Compare
ShGKme
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Now it is not possible to use this button as a link:
- No opening in a new tab with Middle mouse click or its context menu
- No preview address on hover
However, previously this also was not a correct link:
- It has a text "Copy link to clipboard", which represents an action, not a link
- Click on the link did not open the page
- Doesn't work well with keyboard navigation around other buttons (but could be fixed by
tabindex=0)
I'm voting for a button here.
susnux
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace ActionLink with ActionButton on sharing tab for better focus purposes
Summary
No visual changes.
Checklist