Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle error in previews for files versions #41617

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Handle error in previews for files versions #41617

merged 1 commit into from
Nov 21, 2023

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Nov 20, 2023 •
edited
Loading

Before After
image Screenshot from 2023-11-20 15-25-48

@artonge artonge self-assigned this Nov 20, 2023
@artonge artonge changed the title Artonge/fix/error_files_versions_previews Handle error in previews for files versions Nov 20, 2023
@artonge artonge added this to the Nextcloud 28 milestone Nov 20, 2023
@blizzz blizzz mentioned this pull request Nov 20, 2023
Merged
5 tasks
@artonge artonge force-pushed the artonge/fix/error_files_versions_previews branch from 69bb92e to 7d21377 Compare November 20, 2023 14:25
@artonge artonge requested review from a team, szaimen, sorbaugh, emoral435, susnux and Pytal and removed request for a team and sorbaugh November 20, 2023 14:25
susnux
susnux approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artonge
Handle error in previews for files versions
6896724 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/fix/error_files_versions_previews branch from 7d21377 to 6896724 Compare November 20, 2023 17:12
@artonge artonge merged commit ff92a0a into master Nov 21, 2023
42 checks passed
@artonge artonge deleted the artonge/fix/error_files_versions_previews branch November 21, 2023 09:55
@artonge
Copy link
Contributor Author

artonge commented Feb 5, 2024

/backport to stable27

@backportbot backportbot bot mentioned this pull request Feb 5, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@susnux susnux susnux approved these changes

@Pytal Pytal Pytal approved these changes

@szaimen szaimen Awaiting requested review from szaimen szaimen was automatically assigned from nextcloud/server-frontend

@emoral435 emoral435 Awaiting requested review from emoral435 emoral435 was automatically assigned from nextcloud/server-frontend

Assignees

@artonge artonge

Labels
bug feature: versions javascript
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
4 participants
@artonge @AndyScherzinger @susnux @Pytal