Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger default action when open file initial state is set #41648

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Nov 21, 2023

Reimplementation of #27102 for F2V
Fix: #41467

@artonge artonge self-assigned this Nov 21, 2023
@artonge artonge requested review from susnux and Pytal November 21, 2023 18:45
@artonge artonge added this to the Nextcloud 28 milestone Nov 21, 2023
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! But got some comments for you

apps/files/src/components/FilesListVirtual.vue Outdated Show resolved Hide resolved
apps/files/src/components/FilesListVirtual.vue Outdated Show resolved Hide resolved
@artonge artonge force-pushed the artonge/feat/restore_openfile branch 2 times, most recently from b80b095 to c891f1e Compare November 21, 2023 19:10
@artonge artonge requested a review from susnux November 21, 2023 19:12
@artonge artonge enabled auto-merge November 21, 2023 19:12
@artonge
Copy link
Contributor Author

artonge commented Nov 21, 2023

/compile amend /

Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the artonge/feat/restore_openfile branch from c891f1e to c7e2c34 Compare November 21, 2023 19:45
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@artonge artonge merged commit 2310638 into master Nov 22, 2023
42 checks passed
@artonge artonge deleted the artonge/feat/restore_openfile branch November 22, 2023 06:30
@blizzz blizzz mentioned this pull request Nov 22, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: shared file link opens folder, not file
4 participants