Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Subscribe to navigation changes on mounted for Unified search #41687

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 23, 2023

Summary

Prevent too early calls that cause error, as the component is not yet mounted and thus this.$el does not exists.

Screenshot_20231123_132011

Checklist

@susnux susnux requested review from artonge, Fenn-CS, Pytal and a team November 23, 2023 12:22
@susnux
Copy link
Contributor Author

susnux commented Nov 23, 2023

/backport to stable28

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@AndyScherzinger AndyScherzinger added this to the Nextcloud 29 milestone Nov 23, 2023
@susnux susnux merged commit a9c627c into master Nov 23, 2023
40 of 42 checks passed
@susnux susnux deleted the fix/unified-search-view branch November 23, 2023 20:27
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants