fix(core): app icon alignment in app menu #41923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
requested review from
SystemKeeper,
juliushaertl,
marcoambrosini and
nimishavijay
marcoambrosini
approved these changes
Nov 30, 2023
szaimen
reviewed
Nov 30, 2023
| @@ -270,6 +270,10 @@ $header-icon-size: 20px; | |||
| .app-icon { | |||
| position: relative; | |||
| height: 44px; | |||
| width: 48px; | |||
There was a problem hiding this comment.
using 44px here maybe indeed would lookt better?
AndyScherzinger
approved these changes
Nov 30, 2023
|
/backport to stable28 |
8 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the app menu popover (on a small screen) the icon was aligned by fixed padding. But the calculation of padding doesn't take into account the actual menu item size.
It results in:
Changed to a fixed size + flex.
Screenshots
Note
I kept the width the same as it was before (44x48px), but I'd also propose to make it
44x44.Checklist