fix: Properly fetch version from shared files by accessing the owner storage version #41944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
juliushaertl
force-pushed
the
fix/shared-versions
branch
from
8a9ff88
to
8390a04
Compare
|
/backport to stable28 |
|
/backport to stable27 |
AndyScherzinger
approved these changes
Dec 4, 2023
|
I'll have a look at the psalm errors |
juliushaertl
force-pushed
the
fix/shared-versions
branch
4 times, most recently
from
841f3bb
to
80436d7
Compare
artonge
reviewed
Dec 5, 2023
juliushaertl
force-pushed
the
fix/shared-versions
branch
from
80436d7
to
91faf59
Compare
artonge
approved these changes
Dec 6, 2023
…storage version Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
fix/shared-versions
branch
from
91faf59
to
7550574
Compare
8 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File versions of shared files are located in the owners root, so we need special handling to obtain the version file.
This fixes version previews for shared files and in combination with nextcloud/richdocuments#3330 version browsing of shared office files