fix(files): Correctly handle dropping folders on file list #41975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable28 |
This comment was marked as off-topic.
This comment was marked as off-topic.
AndyScherzinger
force-pushed
the
fix/files-handle-drop-folders-correctly
branch
from
612aab2
to
0a1ba4e
Compare
|
/compile / |
artonge
reviewed
Dec 5, 2023
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/files-handle-drop-folders-correctly
branch
from
0a1ba4e
to
0d75a41
Compare
artonge
approved these changes
Dec 6, 2023
skjnldsv
approved these changes
Dec 6, 2023
skjnldsv
added
4. to release
|
Thank you 🙇 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If you currently drop a folder on on the files app it uploads the folder as an empty file. This happens as
DataTransferhandles folders like files.So instead we need to make use of the
FileSystem API, which is also supported by any of our supported browsers.This will handle recursive uploads of folders per Drag&Drop.
Screencast
After ✨
vokoscreenNG-2023-12-02_03-04-21.mp4
Before 🐛
vokoscreenNG-2023-12-02_03-06-47.mp4
Checklist