Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cypress): Wait for network requests to finish when using the FilePicker #42066

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Dec 6, 2023

Summary

Wait for the COPY or MOVE requests to finish before asserting any content changes on the files app in the files copy and move Cypress tests.

Checklist

…Picker

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added 3. to review Waiting for reviews feature: files tests Related to tests labels Dec 6, 2023
@susnux susnux requested review from skjnldsv, a team, szaimen, emoral435 and Pytal and removed request for a team December 6, 2023 16:08
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes more sense! 🚀

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 6, 2023
@Pytal Pytal merged commit 089aec8 into master Dec 6, 2023
41 checks passed
@Pytal Pytal deleted the fix/cypress-wait-for-network-requests branch December 6, 2023 18:49
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: files tests Related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants