Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(joblist): also reset last_run timestamp on updating an existing job #42305

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Dec 15, 2023

Scheduling a job check after a certain time does not update the last_run timestamp. That means when want to reschedule a job that has a last_run in the future (as happens for the OOO and Office Hours automation), the job is checked but not run.

Checklist

Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala added bug 3. to review Waiting for reviews labels Dec 15, 2023
@miaulalala miaulalala added this to the Nextcloud 29 milestone Dec 15, 2023
@miaulalala miaulalala self-assigned this Dec 15, 2023
@miaulalala miaulalala requested review from ArtificialOwl, icewind1991 and Altahrim and removed request for a team December 15, 2023 10:52
@miaulalala
Copy link
Contributor Author

@nickvergessen backport or no?

@nickvergessen
Copy link
Member

Would make sense 🙈

@nickvergessen nickvergessen merged commit a29b0b4 into master Dec 15, 2023
49 checks passed
@nickvergessen nickvergessen deleted the fix/reset-last-run-joblist branch December 15, 2023 20:42
@nickvergessen
Copy link
Member

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
Development

Successfully merging this pull request may close these issues.

[Bug]: Out of office status automation does not set nor reset user status
3 participants