Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(files): added ability to escape out of all selection when focused #42415

Merged

Conversation

emoral435
Copy link
Contributor

☑️ Resolves #42204

🖼️ Screenshots

🏚️ Before 🏡 After
before after

🚧 Summary

Enabled the user to be able to escape out of the selections of files that they used - only when they had the selection checkbox already focused. This is so that if the user presses escape on any other element or just by accident, it will only clear everything if they where already working with the selection text boxes!

Checklist

@emoral435
Copy link
Contributor Author

/backport to stable28

@skjnldsv
Copy link
Member

Good idea!

@emoral435 emoral435 force-pushed the feat/add-escape-option-to-selection-of-files-while-focused branch from c00c107 to 6d367a1 Compare December 21, 2023 14:49
@emoral435 emoral435 force-pushed the feat/add-escape-option-to-selection-of-files-while-focused branch from 6d367a1 to 14b1811 Compare December 21, 2023 15:24
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
@emoral435 emoral435 force-pushed the feat/add-escape-option-to-selection-of-files-while-focused branch from 14b1811 to e1940ba Compare December 21, 2023 16:38
@emoral435 emoral435 merged commit e24efd1 into master Dec 21, 2023
41 checks passed
@emoral435 emoral435 deleted the feat/add-escape-option-to-selection-of-files-while-focused branch December 21, 2023 18:59
@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to click ESC to reset selected files
3 participants