Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dav): undeclared $cache property #42422

Merged
merged 1 commit into from
Dec 21, 2023
Merged

fix(dav): undeclared $cache property #42422

merged 1 commit into from
Dec 21, 2023

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Dec 21, 2023 •
edited
Loading

After #42380

Fails on 8.3 https://github.com/nextcloud/server/actions/runs/7286709234/job/19858533093
Manual run for this PR: https://github.com/nextcloud/server/actions/runs/7288786922

1) OCA\DAV\Tests\unit\CalDAV\Status\StatusServiceTest::testNoUser
Creation of dynamic property OCA\DAV\Tests\unit\CalDAV\Status\StatusServiceTest::$cache is deprecated

/__w/server/server/apps/dav/tests/unit/CalDAV/Status/StatusServiceTest.php:64

2) OCA\DAV\Tests\unit\CalDAV\Status\StatusServiceTest::testOOOInEffect
Creation of dynamic property OCA\DAV\Tests\unit\CalDAV\Status\StatusServiceTest::$cache is deprecated

/__w/server/server/apps/dav/tests/unit/CalDAV/Status/StatusServiceTest.php:64

3) OCA\DAV\Tests\unit\CalDAV\Status\StatusServiceTest::testNoCalendars
Creation of dynamic property OCA\DAV\Tests\unit\CalDAV\Status\StatusServiceTest::$cache is deprecated

/__w/server/server/apps/dav/tests/unit/CalDAV/Status/StatusServiceTest.php:64

4) OCA\DAV\Tests\unit\CalDAV\Status\StatusServiceTest::testNoCalendarEvents
Creation of dynamic property OCA\DAV\Tests\unit\CalDAV\Status\StatusServiceTest::$cache is deprecated

/__w/server/server/apps/dav/tests/unit/CalDAV/Status/StatusServiceTest.php:64

5) OCA\DAV\Tests\unit\CalDAV\Status\StatusServiceTest::testCalendarEvent
Creation of dynamic property OCA\DAV\Tests\unit\CalDAV\Status\StatusServiceTest::$cache is deprecated

/__w/server/server/apps/dav/tests/unit/CalDAV/Status/StatusServiceTest.php:64

6) OCA\DAV\Tests\unit\CalDAV\Status\StatusServiceTest::testCallStatus
Creation of dynamic property OCA\DAV\Tests\unit\CalDAV\Status\StatusServiceTest::$cache is deprecated

/__w/server/server/apps/dav/tests/unit/CalDAV/Status/StatusServiceTest.php:64

7) OCA\DAV\Tests\unit\CalDAV\Status\StatusServiceTest::testInvisibleStatus
Creation of dynamic property OCA\DAV\Tests\unit\CalDAV\Status\StatusServiceTest::$cache is deprecated

/__w/server/server/apps/dav/tests/unit/CalDAV/Status/StatusServiceTest.php:64

8) OCA\DAV\Tests\unit\CalDAV\Status\StatusServiceTest::testDNDStatus
Creation of dynamic property OCA\DAV\Tests\unit\CalDAV\Status\StatusServiceTest::$cache is deprecated

/__w/server/server/apps/dav/tests/unit/CalDAV/Status/StatusServiceTest.php:64

@skjnldsv
fix(dav): undeclared $cache property
11096e2 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added this to the Nextcloud 29 milestone Dec 21, 2023
@skjnldsv skjnldsv requested review from miaulalala and a team December 21, 2023 13:24
@skjnldsv skjnldsv self-assigned this Dec 21, 2023
@skjnldsv skjnldsv requested review from ArtificialOwl, icewind1991 and sorbaugh and removed request for a team December 21, 2023 13:25
@skjnldsv
Copy link
Member Author

/backport to stable28

@skjnldsv skjnldsv merged commit 0dcea03 into master Dec 21, 2023
51 of 52 checks passed
@skjnldsv skjnldsv deleted the fix/cache-tests-undefined branch December 21, 2023 13:45
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 21, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@sorbaugh sorbaugh sorbaugh approved these changes

@miaulalala miaulalala Awaiting requested review from miaulalala

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug feature: dav
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @AndyScherzinger @sorbaugh