Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theming): Add adjusted color versions of default background #42424

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Dec 21, 2023

Summary

The color was adjusted by @jancborchardt for better / required contrast of the app menu

Checklist

…etter app-menu contrast

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
Copy link
Contributor Author

susnux commented Dec 21, 2023

/backport to stable28

@ShGKme
Copy link
Contributor

ShGKme commented Dec 22, 2023

I wonder if we should change attribution here, as it is not an original image anymore.

'kamil-porembinski-clouds.jpg' => [
'attribution' => 'Clouds (Kamil Porembiński, CC BY-SA)',
'description' => 'Background picture of white clouds on in front of a blue sky',
'attribution_url' => 'https://www.flickr.com/photos/paszczak000/8715851521/',
'primary_color' => self::DEFAULT_COLOR,
],

@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BITV]: Replace default background image with darker one to pass a11y contrasts on menu
3 participants