-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
AppAPI: allow to bypass Two-Factor #42479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+25
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if ($this->session->exists('app_password') || $this->twoFactorManager->isTwoFactorAuthenticated($user)) { | ||
if ($this->session->exists('app_password') | ||
|| $this->session->exists('app_api') | ||
|| $this->twoFactorManager->isTwoFactorAuthenticated($user)) { |
Check notice
Code scanning / Psalm
PossiblyNullArgument
Argument 1 of OC\Authentication\TwoFactorAuth\Manager::isTwoFactorAuthenticated cannot be null, possibly null value provided
andrey18106
approved these changes
Dec 25, 2023
bigcat88
added a commit
to nextcloud/app_api
that referenced
this pull request
Dec 27, 2023
ChristophWurst
approved these changes
Dec 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but didn't test
Please squash your commits into one
CI failure seems related, please fix and squash in this PR
|
ce4c53b
to
489b816
Compare
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
489b816
to
26d343d
Compare
/backport to stable28 |
/backport to stable27 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AppAPI must support passing two-factor authentication so that ExApps can work in such systems.
By design they should do so.
Original issue where it was discovered(we just completely forgot about two-factor auth):
nextcloud/app_api#181
Since the context_chat was already released we should provide a fix for this situation.
Also the backport to stable28 branch is required, as this is a bug that blocks all Apps developed for AppAPI to work in most production systems.
If possible, also a backport to stable27 branch will be nice.
Ref:
Checklist