Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): open menu on right click position #42500

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

skjnldsv
Copy link
Member

Fix #41721

image

@skjnldsv skjnldsv added this to the Nextcloud 29 milestone Dec 27, 2023
@skjnldsv skjnldsv requested a review from a team December 27, 2023 15:29
@skjnldsv skjnldsv self-assigned this Dec 27, 2023
@skjnldsv skjnldsv requested review from nfebe, sorbaugh and emoral435 and removed request for a team December 27, 2023 15:29
@skjnldsv
Copy link
Member Author

/backport d409681 to stable28

Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried on my dev browser, and LGTM! Really clean solution :)

@SystemKeeper

This comment was marked as resolved.

@susnux
Copy link
Contributor

susnux commented Dec 31, 2023

the menu is hidden behind the left sidebar:

I think this happens because files is not using NcContent but some custom mounting of NcAppContent and NcAppSidebar instead?

@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 2, 2024

Is it expected to always open the menu to the left, when the sidebar is open?

Yes and no. I'll see if I can improve this further today :)

@skjnldsv skjnldsv force-pushed the fix/files-menu-mouse-open branch from d409681 to 8991da0 Compare January 2, 2024 13:54
@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 2, 2024

@SystemKeeper @susnux fixed!

image

@skjnldsv skjnldsv requested a review from SystemKeeper January 2, 2024 14:04
@SystemKeeper

This comment was marked as resolved.

@skjnldsv skjnldsv force-pushed the fix/files-menu-mouse-open branch from 8991da0 to eddea1c Compare January 3, 2024 07:11
@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 3, 2024

Done @SystemKeeper

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the fix/files-menu-mouse-open branch from eddea1c to dd0fb2e Compare January 3, 2024 07:35
@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 3, 2024

/compile

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 3, 2024
@skjnldsv skjnldsv enabled auto-merge January 3, 2024 08:00
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv merged commit 29e6f06 into master Jan 3, 2024
42 checks passed
@skjnldsv skjnldsv deleted the fix/files-menu-mouse-open branch January 3, 2024 08:16
@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 3, 2024

/backport dd0fb2e to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Right click menu should open at cursor position
5 participants