-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files): open menu on right click position #42500
Conversation
/backport d409681 to stable28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried on my dev browser, and LGTM! Really clean solution :)
This comment was marked as resolved.
This comment was marked as resolved.
I think this happens because files is not using NcContent but some custom mounting of NcAppContent and NcAppSidebar instead? |
Yes and no. I'll see if I can improve this further today :) |
d409681
to
8991da0
Compare
@SystemKeeper @susnux fixed! |
This comment was marked as resolved.
This comment was marked as resolved.
8991da0
to
eddea1c
Compare
Done @SystemKeeper |
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
eddea1c
to
dd0fb2e
Compare
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
The backport to stable28 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b fix/foo-stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28 Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
/backport dd0fb2e to stable28 |
Fix #41721