Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SVG's for social media links #42586

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Fix SVG's for social media links #42586

merged 1 commit into from
Jan 5, 2024

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Jan 4, 2024 •
edited
Loading

Summary

Fix SVG's for social media links

Before After
image image
image

Checklist

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Jan 4, 2024
@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Jan 4, 2024
@emoral435
Copy link
Contributor

/backport to stable28

@emoral435
Copy link
Contributor

I'll wait for @nimishavijay 's response on the color before giving a review, but it looks good to me - if she clears it, i'll sign off on it :)

@emoral435
Copy link
Contributor

I also saw that in the issue itself, several designers agreed with making the SVG's the same text-black that we use (ping me if you need the hex) - so that may be preferable

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/41860-fix-svgs-for-social-media-links branch from 1987d31 to ec4f20e Compare January 5, 2024 09:08
szaimen
szaimen approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from design perspective :)

@JuliaKirschenheuter
Fix SVG's for social media links
eed6817 
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/41860-fix-svgs-for-social-media-links branch from 58584d3 to eed6817 Compare January 5, 2024 10:01
ShGKme
ShGKme approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from implementation perspective

@JuliaKirschenheuter JuliaKirschenheuter merged commit fdb4e77 into master Jan 5, 2024
50 checks passed
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/41860-fix-svgs-for-social-media-links branch January 5, 2024 11:50
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 5, 2024
Merged
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@szaimen szaimen szaimen approved these changes

@emoral435 emoral435 Awaiting requested review from emoral435

@Pytal Pytal Awaiting requested review from Pytal

@susnux susnux Awaiting requested review from susnux

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
4 participants
@JuliaKirschenheuter @emoral435 @ShGKme @szaimen