-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh(core): replaced previous native a element with NcButton #42636
enh(core): replaced previous native a element with NcButton #42636
Conversation
3a83f25
to
a2c311f
Compare
a2c311f
to
d8c9e5f
Compare
d8c9e5f
to
6aebb04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks fine now, thank you for the changes.
Don't forget to remove the commented lines :p
6aebb04
to
5128daf
Compare
Gotcha! Will remove the comments now that you have cleared it :) Also dont mind the cherry pick, that was a mistake! |
5128daf
to
f7ba102
Compare
f7ba102
to
b01377d
Compare
/backport to stable28 |
b01377d
to
c571387
Compare
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
c571387
to
707c1c0
Compare
The backport to stable28 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b fix/foo-stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28 Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Summary
Replaces native element with the NcButton primary button, that works with contrast, defines the role of the element as
role="button"
, keeps the same logic, and added the<img/>
elements alt attribute.Once this passes all reviews, I will remove all the commented out code unless you guys wish to leave it there :)
🖼️ Screenshots
Checklist