Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SharingEntrySimple needs ul or ol around it #42709

Merged
merged 2 commits into from
Jan 11, 2024
Merged

SharingEntrySimple needs ul or ol around it #42709

merged 2 commits into from
Jan 11, 2024

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Jan 11, 2024 •
edited
Loading

Close #42694

This is best reviewed like this: https://github.com/nextcloud/server/pull/42709/files?diff=unified&w=1

Before After
image image
image image
For my own testing 
docker run -it --rm ^
--name nextcloud-easy-test ^
-p 8443:443 ^
-e SERVER_BRANCH=enh/42694/put-li-into-ul ^
-e COMPILE_SERVER=1 ^
--volume="nextcloud_easy_test_npm_cache_volume:/var/www/.npm" ^
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added this to the Nextcloud 29 milestone Jan 11, 2024
@szaimen szaimen changed the title sharing-entry__reshare needs ul or ol around it sharing-entry__reshare needs ul or ol around it Jan 11, 2024
@szaimen szaimen changed the title sharing-entry__reshare needs ul or ol around it SharingEntrySimple needs ul or ol around it Jan 11, 2024
@szaimen szaimen changed the title SharingEntrySimple needs ul or ol around it SharingEntrySimple needs ul or ol around it Jan 11, 2024
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 11, 2024
@szaimen szaimen marked this pull request as ready for review January 11, 2024 13:36
emoral435
emoral435 approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@szaimen
sharing-entry__reshare needs ul or ol around it
420b3d0 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen
Copy link
Contributor Author

szaimen commented Jan 11, 2024

/backport 420b3d0 to stable28

@szaimen
Copy link
Contributor Author

szaimen commented Jan 11, 2024

/compile

@nextcloud-command
chore(assets): Recompile assets
9687f8d 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@szaimen szaimen disabled auto-merge January 11, 2024 17:21
@szaimen szaimen merged commit 53817cb into master Jan 11, 2024
40 of 41 checks passed
@szaimen szaimen deleted the enh/42694/put-li-into-ul branch January 11, 2024 17:21
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 11, 2024
Merged
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@emoral435 emoral435 emoral435 approved these changes

@susnux susnux Awaiting requested review from susnux

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@artonge artonge Awaiting requested review from artonge

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review Waiting for reviews accessibility
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

[BITV]: HTML Structure inside of sharing tab is not correct
4 participants
@szaimen @ShGKme @emoral435 @nextcloud-command