-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate available temp space check to new SetupCheck API #42839
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
I think it would make sense to merge both checks and always use path from |
come-nc
added
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
labels
Jan 22, 2024
come-nc
requested review from
nickvergessen,
susnux,
a team,
ArtificialOwl,
Altahrim and
nfebe
and removed request for
a team
January 22, 2024 13:28
nickvergessen
approved these changes
Jan 22, 2024
susnux
approved these changes
Jan 22, 2024
come-nc
force-pushed
the
enh/migrate-mysql-utf8mb4-setupcheck
branch
2 times, most recently
from
January 23, 2024 16:34
2916812
to
10664e9
Compare
Base automatically changed from
enh/migrate-mysql-utf8mb4-setupcheck
to
master
January 25, 2024 10:18
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
It will now show available space and path of both PHP and Nextcloud temporary directories if they differ. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
enh/migrate-s3tempspace-setupcheck
branch
from
January 25, 2024 10:48
200804e
to
9add64f
Compare
nickvergessen
approved these changes
Jan 25, 2024
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #41364
Summary
Migrate available temp space check to new SetupCheck API.
Also put info in the check and not in the log file.
Checklist