Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable26] fix(manifest): Check if app exists instead of accessing null as an array #42866

Merged
merged 1 commit into from
Jan 17, 2024
Merged

[stable26] fix(manifest): Check if app exists instead of accessing null as an array #42866

merged 1 commit into from
Jan 17, 2024

Conversation

nickvergessen
Copy link
Member

Backport #42862

@nickvergessen
fix(manifest): Check if app exists instead of accessing null as an array
ea8553f 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 26.0.11 milestone Jan 17, 2024
@nickvergessen nickvergessen self-assigned this Jan 17, 2024
@nickvergessen nickvergessen mentioned this pull request Jan 17, 2024
Merged
@skjnldsv skjnldsv requested review from a team, ArtificialOwl, icewind1991 and provokateurin and removed request for a team January 17, 2024 10:46
@backportbot backportbot bot closed this Jan 17, 2024
@backportbot backportbot bot force-pushed the backport/42862/stable26 branch from ea8553f to d65d0bd Compare January 17, 2024 10:53
@nickvergessen nickvergessen requested review from juliusknorr, skjnldsv and provokateurin and removed request for ArtificialOwl and icewind1991 January 17, 2024 10:55
@nickvergessen nickvergessen reopened this Jan 17, 2024
@nickvergessen
Copy link
Member Author

I had forgotten to delete the backport bot comment in #42862 when doing it manually right away.
the bot pushed an empty branch and had a conflict, so I pushed my local branch again 🙊

@nickvergessen nickvergessen merged commit 711ee5e into stable26 Jan 17, 2024
91 of 103 checks passed
@nickvergessen nickvergessen deleted the backport/42862/stable26 branch January 17, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@provokateurin provokateurin Awaiting requested review from provokateurin

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews bug feature: theming
Projects
None yet
Milestone
Nextcloud 26.0.11
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @juliusknorr @skjnldsv @provokateurin