Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(settings): stop reloading after force-enabling an app #42913

Merged
merged 1 commit into from
Jan 31, 2024
Merged

fix(settings): stop reloading after force-enabling an app #42913

merged 1 commit into from
Jan 31, 2024

Conversation

skjnldsv
Copy link
Member

Steps

  1. have an incompatible app
  2. Click Allow untested app
  3. The page reloads

Fixed:

The page does NOT reload anymore

Peek.18-01-2024.09-27.mp4

@skjnldsv skjnldsv added 3. to review Waiting for reviews papercut Annoying recurring issue with possibly simple fix. feature: settings labels Jan 18, 2024
@skjnldsv skjnldsv added this to the Nextcloud 29 milestone Jan 18, 2024
@skjnldsv skjnldsv requested a review from a team January 18, 2024 08:28
@skjnldsv skjnldsv self-assigned this Jan 18, 2024
@skjnldsv skjnldsv requested review from Fenn-CS, szaimen, sorbaugh and artonge and removed request for a team January 18, 2024 08:28
artonge
artonge approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣 Not sure why, but this makes me laugh

@skjnldsv
Copy link
Member Author

🤣 Not sure why, but this makes me laugh

It's the little things™ ✨ ✨ ✨ 🙈

@skjnldsv

This comment was marked as resolved.

Sign in to view
szaimen
szaimen approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to work.

Maybe the idea of a reload was that a potential icon is directly shown in the header which it might not be now?

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 18, 2024
@skjnldsv
Copy link
Member Author

Maybe the idea of a reload was that a potential icon is directly shown in the header which it might not be now?

That's what happens when you enable an app, not force-enable :)

@skjnldsv skjnldsv force-pushed the fix/settings-apps-stop-reload-force-enabl branch from 28114a2 to a95cd15 Compare January 31, 2024 12:24
@skjnldsv
fix(settings): stop reloading after force-enabling an app
ffae800 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the fix/settings-apps-stop-reload-force-enabl branch from a95cd15 to ffae800 Compare January 31, 2024 15:49
@skjnldsv skjnldsv merged commit 82e02a7 into master Jan 31, 2024
93 of 94 checks passed
@skjnldsv skjnldsv deleted the fix/settings-apps-stop-reload-force-enabl branch January 31, 2024 16:35
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@szaimen szaimen szaimen approved these changes

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-frontend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish feature: apps management feature: settings papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @artonge @szaimen