Migrate fair use of free push service check to new SetupCheck API #42939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
come-nc
requested review from
nickvergessen,
a team,
ArtificialOwl,
Altahrim and
nfebe
and removed request for
a team
come-nc
force-pushed
the
enh/migrate-s3tempspace-setupcheck
branch
from
200804e to
9add64f
Compare
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
enh/migrate-fairuseoffreepushservice-setupcheck
branch
from
d4f9d9b to
67541f2
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
nickvergessen
approved these changes
Jan 25, 2024
| * Check if is fair use of free push service | ||
| */ | ||
| private function isFairUseOfFreePushService(): bool { | ||
| $rateLimitReached = (int) $this->config->getAppValue('notifications', 'rate_limit_reached', '0'); |
Check notice
Code scanning / Psalm
DeprecatedMethod Note
artonge
approved these changes
Jan 25, 2024
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #41364
Summary
Migrate fair use of free push service check to new SetupCheck API
Checklist