Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable the internal s3sdk multi part copy logic #43086

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

icewind1991
Copy link
Member

We have our own logic so just set the threshold in the library to 2^64-1

@icewind1991 icewind1991 requested review from a team, ArtificialOwl, Altahrim and nfebe and removed request for a team January 24, 2024 16:42
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jan 24, 2024
@icewind1991 icewind1991 added this to the Nextcloud 29 milestone Jan 24, 2024
@icewind1991
Copy link
Member Author

/backport to stable28

@icewind1991
Copy link
Member Author

/backport to stable27

Copy link
Contributor

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay.

However, if default is max, then it might be unnecessary?

@icewind1991 icewind1991 force-pushed the s3-internal-multipart-copy-disable branch 2 times, most recently from 518e8fe to 8cbfecf Compare March 5, 2024 11:17
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the s3-internal-multipart-copy-disable branch from 8cbfecf to c54f7bd Compare March 6, 2024 14:32
@icewind1991 icewind1991 merged commit efcb16f into master Mar 7, 2024
160 checks passed
@icewind1991 icewind1991 deleted the s3-internal-multipart-copy-disable branch March 7, 2024 09:13
@blizzz blizzz mentioned this pull request Mar 7, 2024
@skjnldsv skjnldsv added the bug label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants