Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] fix(files): Make the navigation reactive to view changes and show also sub routes as active #43119

Merged
merged 6 commits into from
Jan 25, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jan 25, 2024

Backport of #42992

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@backportbot backportbot bot added this to the Nextcloud 28.0.2 milestone Jan 25, 2024
@blizzz blizzz mentioned this pull request Jan 25, 2024
@blizzz
Copy link
Member

blizzz commented Jan 25, 2024

@susnux could you double check this backport?

@susnux susnux force-pushed the backport/42992/stable28 branch from 79892d4 to 8dd3621 Compare January 25, 2024 16:37
@susnux
Copy link
Contributor

susnux commented Jan 25, 2024

The problem is this is based on #43108 on master I will check

susnux and others added 5 commits January 25, 2024 17:43
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…ion entries

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux force-pushed the backport/42992/stable28 branch from 8dd3621 to 732283f Compare January 25, 2024 16:46
@susnux
Copy link
Contributor

susnux commented Jan 25, 2024

Tested and works for me!

@susnux susnux marked this pull request as ready for review January 25, 2024 16:47
@susnux susnux requested a review from nickvergessen January 25, 2024 16:50
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seconded, works on my local env!

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 25, 2024
@blizzz blizzz merged commit 400f459 into stable28 Jan 25, 2024
50 of 53 checks passed
@blizzz blizzz deleted the backport/42992/stable28 branch January 25, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants