Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(db): Make dirty query logging available in production #43185

Merged
merged 1 commit into from
Jan 30, 2024
Merged

feat(db): Make dirty query logging available in production #43185

merged 1 commit into from
Jan 30, 2024

Conversation

ChristophWurst
Copy link
Member

  • Resolves: none

Summary

Makes #42345 usable in production environments.

⚠️ depending on the number of dirty queries detected, this may log very often ⚠️

How to test

  1. Set loglevel to 3
  2. Set loglevel_dirty_database_queries to 3
  3. Log into Nextcloud with user_status enabled
  4. Look into nextcloud.log

master: nothing related to dirty queries
here: #43109 logged with level 3

Checklist

@ChristophWurst ChristophWurst self-assigned this Jan 29, 2024
nickvergessen
nickvergessen approved these changes Jan 29, 2024
View reviewed changes
lib/private/DB/Connection.php Outdated Show resolved Hide resolved
AndyScherzinger
AndyScherzinger approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formal approval, not a technical one ;)

@nickvergessen
Copy link
Member

Time to fixup and merge

@ChristophWurst
feat(db): Make dirty query logging available in production
911ab39 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 30, 2024
@nickvergessen nickvergessen merged commit e0053e1 into master Jan 30, 2024
131 of 134 checks passed
@nickvergessen nickvergessen deleted the feat/db/dirty-queries-production branch January 30, 2024 11:05
@ChristophWurst ChristophWurst mentioned this pull request Feb 1, 2024
Draft
10 tasks
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@Altahrim Altahrim Altahrim approved these changes

@juliushaertl juliushaertl juliushaertl approved these changes

@sorbaugh sorbaugh Awaiting requested review from sorbaugh

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: logging
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ChristophWurst @nickvergessen @AndyScherzinger @Altahrim @juliushaertl