Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Force github CI for tests failing on self-hosted runners #43210

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Jan 30, 2024

Summary

2 jobs are always failing on self hosted runners, so for now force them on github CI to avoid false-negative.

Checklist

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added the 3. to review Waiting for reviews label Jan 30, 2024
@come-nc come-nc self-assigned this Jan 30, 2024
@come-nc come-nc added this to the Nextcloud 29 milestone Jan 30, 2024
@come-nc
Copy link
Contributor Author

come-nc commented Jan 30, 2024

smb-kerberos-sso is flaky on github CI as well, it failed 😢

@come-nc
Copy link
Contributor Author

come-nc commented Jan 30, 2024

For php8.3-s3 it works.

@come-nc
Copy link
Contributor Author

come-nc commented Feb 1, 2024

@susnux I see you have pushed things to docker-ci, what is your take on this, should we merge it? Or is there a better solution?

@susnux
Copy link
Contributor

susnux commented Feb 1, 2024

I see you have pushed things to docker-ci, what is your take on this, should we merge it? Or is there a better solution?

Nothing related to this. So probably we need this until someone can figure out whats up with kerberos

@nickvergessen nickvergessen merged commit 2e48820 into master Feb 1, 2024
135 of 139 checks passed
@nickvergessen nickvergessen deleted the fix/use-github-ci-for-s3-tests branch February 1, 2024 14:49
@susnux
Copy link
Contributor

susnux commented Feb 1, 2024

@come-nc
Copy link
Contributor Author

come-nc commented Feb 1, 2024

Kerberos still failing?

nextcloud/server/actions/runs/7712512770/job/21024244130

Yes as stated above: #43210 (comment)
I do not know what is wrong with it.

@susnux
Copy link
Contributor

susnux commented Feb 2, 2024

But only for PHP8.3 I see this errors, so there might be a real issue with our code?

@nickvergessen
Copy link
Member

But only for PHP8.3 I see this errors, so there might be a real issue with our code?

unknown, I forwarded this internally and an engineer of the team will be assigned to investigate if we can disable it safely or if a work item needs to be scheduled

@nickvergessen
Copy link
Member

Ref #43296

nickvergessen added a commit that referenced this pull request Feb 13, 2024
Replaying #43210
Which was accidentally reverted by
#43515

Signed-off-by: Joas Schilling <coding@schilljs.com>
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants