Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Make the cypress apps management test more reliable #43273

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

nickvergessen
Copy link
Member

Summary

I was able to reproduce most failures that I found for the apps.cy.ts test by adding sleeps in the right places:

Checklist

@nickvergessen nickvergessen added bug 3. to review Waiting for reviews javascript tests Related to tests labels Feb 1, 2024
@nickvergessen nickvergessen added this to the Nextcloud 29 milestone Feb 1, 2024
@nickvergessen nickvergessen self-assigned this Feb 1, 2024
@nickvergessen
Copy link
Member Author

/backport to stable28

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/make-apps-cypress-test-more-reliable branch from 06c9400 to b99749d Compare February 2, 2024 06:04
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 2, 2024
@skjnldsv skjnldsv merged commit 5a8cc42 into master Feb 2, 2024
94 checks passed
@skjnldsv skjnldsv deleted the bugfix/noid/make-apps-cypress-test-more-reliable branch February 2, 2024 15:37
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug javascript tests Related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants