Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): drag leave detection on safari #43330

Merged
merged 2 commits into from
Feb 4, 2024
Merged

fix(files): drag leave detection on safari #43330

merged 2 commits into from
Feb 4, 2024

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Feb 4, 2024

Fix #43135

Before After
old new

@skjnldsv skjnldsv added this to the Nextcloud 29 milestone Feb 4, 2024
@skjnldsv skjnldsv requested a review from a team February 4, 2024 13:10
@skjnldsv skjnldsv self-assigned this Feb 4, 2024
@skjnldsv skjnldsv requested review from Fenn-CS, szaimen and emoral435 and removed request for a team February 4, 2024 13:10
@skjnldsv
Copy link
Member Author

skjnldsv commented Feb 4, 2024

/backport to stable28

@skjnldsv skjnldsv requested a review from susnux February 4, 2024 13:10
@skjnldsv skjnldsv mentioned this pull request Feb 4, 2024
Closed
8 tasks
susnux
susnux approved these changes Feb 4, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not verify this fixes the issue (I have no access to Apple devices), but the code makes sense as it seems to be related to this long standing WebKit bug where relatedTarget is unset: https://bugs.webkit.org/show_bug.cgi?id=66547

(Feels like Safari is the new IE).

apps/files/src/components/DragAndDropNotice.vue Outdated Show resolved Hide resolved
@skjnldsv
Copy link
Member Author

skjnldsv commented Feb 4, 2024

Feels like Safari is the new IE

You and me both 😅🥲

@skjnldsv
Copy link
Member Author

skjnldsv commented Feb 4, 2024

/compile rebase-amend /

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 4, 2024
skjnldsv and others added 2 commits February 4, 2024 20:52
@skjnldsv @nextcloud-command
fix(files): drag leave detection on safari
441651c 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv @susnux @nextcloud-command
fix(files): better null relatedTarget event detection
9c2dc4a 
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux
Copy link
Contributor

susnux commented Feb 4, 2024

compile rebase-amend

Thats new? Nice!

@skjnldsv skjnldsv merged commit 3355bdb into master Feb 4, 2024
96 checks passed
@skjnldsv skjnldsv deleted the fix/safari-drag-drop branch February 4, 2024 21:46
@backportbot backportbot bot mentioned this pull request Feb 4, 2024
Merged
2 tasks
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@Fenn-CS Fenn-CS Fenn-CS approved these changes

@szaimen szaimen Awaiting requested review from szaimen szaimen was automatically assigned from nextcloud/server-frontend

@emoral435 emoral435 Awaiting requested review from emoral435 emoral435 was automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files regression
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

[Bug]: NC28.0.2rc4 drag-and-drop still broken on Safari
3 participants
@skjnldsv @susnux @Fenn-CS