[Bugfix]: 'forbidden_chars' added the condition to drop file #43468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrii Rublov <airublev@outlook.com>
…rop-file Signed-off-by: Andrii Rublov <39839367+arublov@users.noreply.github.com>
susnux
requested changes
Feb 9, 2024
| toCheck.forEach(char => { | ||
| if (forbiddenCharacters.indexOf(char) !== -1) { | ||
| showError(t('files', t('files', '"{char}" is not allowed inside a file name.', { char }))) | ||
| throw '#.. is not allowed inside a file name.' |
There was a problem hiding this comment.
Throwing a string is nothing we should do, instead a proper Error should be used.
Suggested change
| throw '#.. is not allowed inside a file name.' | |
| throw new Error(`${char} is not allowed inside a file name.`). |
| @@ -67,6 +70,14 @@ export const handleDrop = async (data: DataTransfer): Promise<Upload[]> => { | |||
| const handleFileUpload = async (file: File, path: string = '') => { | |||
| const uploader = getUploader() | |||
|
|
|||
| const toCheck = file.name.split('') | |||
| toCheck.forEach(char => { | |||
There was a problem hiding this comment.
This seems to be the wrong way and probably performance wise pretty bad, instead I would do something like:
const forbidden = forbiddenCharacters.split('')
if (forbidden.some((char) => file.name.includes(char))) {
// ...
}why? because file name is probably longer than the list of forbidden chars so we reduce the outer loop.
There was a problem hiding this comment.
@susnux thank you for your comments. Yesterday, I submitted that pull request as a draft because I'm still working on it and it's not the final version yet. Today, I'll have the final version for this task. Still, thank you for your comments.
…ud/vue` dependency Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Simon L <szaimen@e.mail.de>
It is not allowed to use slashes within path parameters, so they would need to be encoded. But URL encoded slashes are not suported by Apache, so instead replace slash with space. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…L entities in their names Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
…or uploadPicker Signed-off-by: Andrii Rublov <airublev@outlook.com>
arublov
pushed a commit
to arublov/server
that referenced
this pull request
Feb 9, 2024
…p file and added forbiddenCharacters to UploadPicker Signed-off-by: Andrii Rublov <airublev@outlook.com>
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist